Repository navigation
Fix ASCII HTML block starts per CommonMark 0.31.2 - #440
Merged
chrisjsewell merged 8 commits intoNov 9, 2026
Merged
Conversation
A global `re.ASCII` also narrows `\s` in the lookahead after the tag name, so a no-break space or other Unicode space after `<div`, `<pre` or `<script` stopped starting an HTML block, where markdown-it and commonmark.js both start one. Use the scoped `(?a:...)` flag on the tag-name group instead, keeping the capture group so the group numbers are unchanged.
Add upstream markdown-it's own fixture for lowercase declarations (`foo\n<!bar baz>`, from 15.0.0) to `commonmark_extras.md`, and the executablebooks#437 cases to `issue-fixes.md`: lowercase `<!doctype html>`, Unicode lookalikes that must neither open nor close a block, an ASCII mixed-case control, and no-break-space controls after `<div` and `<pre` that must still start a block. The cases from `tests/test_html_block_ascii.py` are all covered there, so that file is removed.
The removed tests/test_html_block_ascii.py also checked that an uppercase <!DOCTYPE html> interrupts a paragraph. Add it to the lowercase-declaration fixture, so every case from that file is now in the port fixtures.
# Conflicts: # tests/test_port/fixtures/commonmark_extras.md # tests/test_port/fixtures/issue-fixes.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #437. Lowercase declarations now interrupt paragraphs, and case-insensitive HTML block tag matching uses ASCII case folding so Unicode lookalikes do not start blocks. Focused regressions cover both cases and an ASCII mixed-case control.
Validation: five input cases failed on the previous implementation; after the fix,
python -m pytest -q tests/passed (1,035 tests), and all applicable pre-commit hooks (including strict mypy and Ruff), plusgit diff --check, passed locally. Initial pre-commit.ci failed because parametrized tests used an untyped decorator; the follow-up commit removes that decorator while retaining all cases. GitHub Actions require maintainer approval and have not executed. No browser or renderer integration was tested.AI assistance was used to develop and validate this change.