Repository navigation
Fix hexadecimal variable initialization example - #1046
MelancholyMing wants to merge 1 commit into
Conversation
Updated hexadecimal variable initialization from 0x24CD to 0x2419.
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
@MelancholyMing See the discussion over in the forum. |
|
Updated hexadecimal variable initialization from 0x24CD to 0x2419. |
| ```cpp | ||
| int m_morales{9241}; // base 10: 0-9 | ||
| int a_apaec{0x24CD}; // base 16: 0-9 and A-F | ||
| int a_apaec{0x2419}; // base 16: 0-9 and A-F |
There was a problem hiding this comment.
As per the forum discussion we'd prefer to keep the hexadecimal version and instead adapt the others for consistency. Although the existing 0x2419 is probably due to a typo, it has the nice property of showcasing that hexadecimal also uses letters.
Also please consider Siebenschläfer's comment regarding the other files. Thanks!
2 participants
Updated hexadecimal variable initialization from 0x24CD to 0x2419.