Repository navigation
Insufficient test cases for "Resistor Color Expert" #3795
Description
I submitted code that passed all the existing tests but failed to correctly handle some actual resistor values in use in the E48 (2% tolerance) and larger series. There are currently no tests for 5-band resistors where the second band is black, which my earlier iteration handled wrongly.
Activity
github-actions commentedon Oct 21, 2024
BethanyG commentedon Oct 22, 2024
Linking forum discussion.
Happy to accept suggested test cases and/or PR. 😄
xanni commentedon Oct 23, 2024
PR created: #3797
BethanyG commentedon Oct 24, 2024
I am going to keep this open until we figure out if we want 3-band cases. I am leaning towards "no", but want to discuss it a bit on the forum first. 😄
tests: add edge-case tests for resistor-color-expert (exercism#3795)
deekshahavaragi commentedon Dec 13, 2025
I’ve opened a PR with the additional edge-case tests discussed here:
PR: #4047
Please let me know if this approach looks good or if any changes are needed. Thanks!
BethanyG commentedon Dec 14, 2025
Hi @deekshahavaragi -- while I appreciate the enthusiasm, the forum discussion related to this came down on the side of no additional edge cases, since they were wandering away from the intent of the exercise. I forgot to close this issue, but will be doing so now.
Additionally, your PR appears to only have made whitespace changes - was that intentional?