[worker] run device run session jobs - #4414
Draft
szdziedzic wants to merge 1 commit into
Draft
szdziedzic wants to merge 1 commit into
szdziedzic wants to merge 1 commit into
Conversation
szdziedzic
added this pull request to stack #4415
September 15, 2026 19:45
szdziedzic
force-pushed
the
szdziedzic-claude/eas-simulator-job-worker
branch
from
September 15, 2026 19:47
f1be515 to
7a78c07
Compare
|
✅ Thank you for adding the changelog entry! |
This was referenced Sep 15, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## szdziedzic-claude/eas-simulator-job-runner #4414 +/- ##
==============================================================================
- Coverage 72.41% 72.39% -0.01%
==============================================================================
Files 986 987 +1
Lines 46678 46747 +69
Branches 9997 10013 +16
==============================================================================
+ Hits 33796 33838 +42
- Misses 11882 11905 +23
- Partials 1000 1004 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Last PR of the stack (#4412 schema, #4413 runner). The worker has to recognize
DeviceRunSession.Jobpayloads and hand them to the runner instead of the steps engine.How
build.ts: in the platform-less branch, a job withtype === 'device-run-session'runs throughrunDeviceRunSessionJobAsync; everything else keeps usingrunGenericJobAsync. The runner validates the payload and rejects with the error to report on the job run.external/turtle.ts: thejobRundispatch message may carryGeneric.Job | DeviceRunSession.Job.service.ts: the Sentryworkflowtag is only set for build jobs; session jobs get ajobTypetag instead, sincetypemeans something different on them.Nothing changes for build jobs or generic jobs. The orchestrator passes the payload through unchanged, so no change is needed there.
Rollout note: the API server must not send
DeviceRunSession.Jobpayloads before the production worker includes this change. An old worker would take the generic branch and fail on the missingsteps, which errors the session loudly rather than hanging. The universe PR that starts sending the payload (admin sessions first) is gated on this deploy.Test Plan
yarn typecheck,yarn lint,yarn fmt:checkpass.🤖 Generated with Claude Code