Conversation
…ascAppId The flag was only checked when the submit profile has an ascAppId. When the App Store Connect app is resolved by bundle identifier instead, `eas submit` still created the internal TestFlight group and invited the team's admins. Fixes expo#4397
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #4397
eas submit -p ios --no-auto-testflight-setupstill creates the internalTeam (Expo)TestFlight group and invites the team's admins when the submit profile has noascAppId.#4136 replaced the
EAS_NO_AUTO_TESTFLIGHT_SETUPcheck with the--auto-testflight-setupflag, but only honored the flag on the existing-app path (ensureTestFlightSetupForExistingAppAsync). When the App Store Connect app is resolved by bundle identifier (ensureAppStoreConnectAppExistsAsync→createAppStoreConnectAppAsync), the group setup still runs unconditionally.How
Run the group setup in
createAppStoreConnectAppAsynconly whenctx.autoTestFlightSetupis true, matchingensureTestFlightSetupForExistingAppAsync. Nothing else changes when the flag is omitted or passed explicitly.eas build --auto-submitandsubmit:internaldon't passautoTestFlightSetupto the submission context, so they still always set up the group.eas buildhas no equivalent flag, so I left that out of this PR.Test Plan
AppProduce-test.ts, which covers group setup withautoTestFlightSetupenabled and disabled. The disabled case fails without this change.src/submittests pass (10 suites, 66 tests), andtsc,oxlintandoxfmt --checkare clean.Submit.flagswith oclif),createSubmissionContextAsync,IosSubmitCommand.runAsync()andsubmitAsync(), with only the Apple and network calls mocked. The profile had noascAppId:--platform ios--platform ios --auto-testflight-setup--platform ios --no-auto-testflight-setup