[eas-cli] Add --upload-source-maps to eas update - #4436
Draft
douglowder wants to merge 2 commits into
Draft
douglowder wants to merge 2 commits into
douglowder wants to merge 2 commits into
Conversation
Upload the source map that expo export emits for each native platform, so EAS Observe can symbolicate stack traces from an update. The maps are not listed in metadata.json, so each one is located from the bundle that metadata.json does name, falling back to a single sibling .map file. sourcesContent is always stripped, which keeps application source text out of EAS storage and gives the map a chance of fitting under the 5 MiB upload limit. A map that is still too large is skipped with a warning; publishing never fails because of a source map. The GraphQL schema for this is not deployed yet, so the new types live in graphql/sourceMapShim.ts. Once expo/universe#30154 ships, regenerate the GraphQL types, delete that file, and repoint its four importers. Grep for ENG-26889. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
✅ Thank you for adding the changelog entry! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4436 +/- ##
==========================================
+ Coverage 72.30% 72.37% +0.07%
==========================================
Files 970 972 +2
Lines 46132 46245 +113
Branches 9902 9927 +25
==========================================
+ Hits 33349 33463 +114
- Misses 11788 11789 +1
+ Partials 995 993 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…urce-maps Only the default value of --source-maps reliably writes a standalone source map file. `false` writes none, and every other value is forwarded to `expo export` on SDK 55+, where `inline` embeds the map in the bundle. Naming only `false` and `inline` let a typo or an unknown mode pass validation and then upload nothing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upload the source map that expo export emits for each native platform, so EAS Observe can symbolicate stack traces from an update.
The maps are not listed in metadata.json, so each one is located from the bundle that metadata.json does name, falling back to a single sibling .map file. sourcesContent is always stripped, which keeps application source text out of EAS storage and gives the map a chance of fitting under the 5 MiB upload limit. A map that is still too large is skipped with a warning; publishing never fails because of a source map.
The GraphQL schema for this is not deployed yet, so the new types live in graphql/sourceMapShim.ts. Once expo/universe#30154 ships, regenerate the GraphQL types, delete that file, and repoint its four importers. Grep for ENG-26889.
Stack created with GitHub Stacks CLI • Give Feedback 💬