Conversation
gwdp
force-pushed
the
gwdp/serve-sim-bitrate-1600
branch
from
September 17, 2026 23:41
2a45a04 to
142d383
Compare
gwdp
force-pushed
the
gwdp/serve-sim-bitrate-1600
branch
from
September 17, 2026 23:47
142d383 to
8ca0352
Compare
|
✅ Thank you for adding the changelog entry! |
gwdp
marked this pull request as ready for review
September 17, 2026 23:48
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4439 +/- ##
=======================================
Coverage 72.30% 72.30%
=======================================
Files 970 970
Lines 46146 46146
Branches 9906 9906
=======================================
Hits 33363 33363
Misses 11788 11788
Partials 995 995 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The preview stream is pinned to 960px and 6 Mbps because H.264 stalled at larger encode sizes. The serve-sim fixes for that are in: #167 sizes H.264 to the negotiated level, #170 recovers a stream that stops decoding, and #171 raises the level in the offer so larger frames encode at all.
Blocked by expo/serve-sim#171 — do not merge before it ships in a released
@expo/serve-sim.Linear: ENG-26485
How
SERVE_SIM_MAX_DIMENSION:960->1600SERVE_SIM_VIDEO_BITRATE:6000000->10000000Android Device Hub constants are unchanged.
Test Plan
yarn testinpackages/build-tools