Skip to content

[build-tools] raise the simulator preview stream to 1600px and 10 Mbps - #4439

Open
gwdp wants to merge 1 commit into
mainfrom
gwdp/serve-sim-bitrate-1600
Open

gwdp wants to merge 1 commit into
mainfrom
gwdp/serve-sim-bitrate-1600

Conversation

@gwdp

@gwdp gwdp commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Why

The preview stream is pinned to 960px and 6 Mbps because H.264 stalled at larger encode sizes. The serve-sim fixes for that are in: #167 sizes H.264 to the negotiated level, #170 recovers a stream that stops decoding, and #171 raises the level in the offer so larger frames encode at all.

Blocked by expo/serve-sim#171 — do not merge before it ships in a released @expo/serve-sim.

Linear: ENG-26485

How

  • SERVE_SIM_MAX_DIMENSION: 960 -> 1600
  • SERVE_SIM_VIDEO_BITRATE: 6000000 -> 10000000

Android Device Hub constants are unchanged.

Test Plan

  • yarn test in packages/build-tools
  • Live check on an EAS worker once serve-sim#171 ships

@gwdp
gwdp force-pushed the gwdp/serve-sim-bitrate-1600 branch from 2a45a04 to 142d383 Compare September 17, 2026 23:41
@gwdp
gwdp force-pushed the gwdp/serve-sim-bitrate-1600 branch from 142d383 to 8ca0352 Compare September 17, 2026 23:47
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@gwdp
gwdp requested a review from szdziedzic September 17, 2026 23:48
@gwdp
gwdp marked this pull request as ready for review September 17, 2026 23:48
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.30%. Comparing base (30a3924) to head (8ca0352).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4439   +/-   ##
=======================================
  Coverage   72.30%   72.30%           
=======================================
  Files         970      970           
  Lines       46146    46146           
  Branches     9906     9906           
=======================================
  Hits        33363    33363           
  Misses      11788    11788           
  Partials      995      995           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant