Conversation
vonovak
added this pull request to stack #4432
September 18, 2026 09:54
This was referenced Sep 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## codex/graphql-abort-signal #4441 +/- ##
==============================================================
+ Coverage 72.43% 72.47% +0.05%
==============================================================
Files 974 974
Lines 46372 46372
Branches 9951 9951
==============================================================
+ Hits 33583 33605 +22
+ Misses 11794 11775 -19
+ Partials 995 992 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vonovak
force-pushed
the
codex/ci-ffmpeg-for-recording-tests
branch
from
September 18, 2026 10:02
aa29e57 to
26406d2
Compare
vonovak
force-pushed
the
codex/ci-ffmpeg-for-recording-tests
branch
from
September 18, 2026 10:19
8fdc898 to
80f1d7b
Compare
vonovak
force-pushed
the
codex/ci-ffmpeg-for-recording-tests
branch
from
September 18, 2026 11:16
80f1d7b to
0f19c64
Compare
The build-tools test that recovers unlisted recordings from a killed host cuts a real MP4 and needs ffprobe. It skipped on every CI run. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D29AEWN9ajZXbzobHUH4fF
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D29AEWN9ajZXbzobHUH4fF
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D29AEWN9ajZXbzobHUH4fF
vonovak
force-pushed
the
codex/ci-ffmpeg-for-recording-tests
branch
from
September 18, 2026 11:17
0f19c64 to
7e95722
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The build-tools test that recovers unlisted recordings from a killed host cuts a real MP4 and needs
ffmpegandffprobe. The Ubuntu runner has none, and the test skipped itself silently, so it never ran on CI.How
Install
ffmpegin the test workflow before the dependency install, and remove the skip guard so the test fails when the tools are missing.Stack 6/6, based on #4435. Verifies the recovery scan added in #4420.
Test plan
The build-tools test run on this PR reports 0 skipped tests. Locally, hiding ffmpeg from
PATHfails the test withspawnSync ffmpeg ENOENT.🤖 Generated with Claude Code
https://claude.ai/code/session_01D29AEWN9ajZXbzobHUH4fF