Link direct submissions as GitHub native stacks#362
Open
ezyang wants to merge 1 commit into
Open
Conversation
[ghstack-poisoned]
Owner
Author
|
Stack from ghstack (oldest at bottom): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct ghstack pull requests already use the base-to-head branch chain required by GitHub Stacked PRs, but GitHub also requires an explicit Stack object. Discover native stack membership during submission, create or append the server-side stack, and retain merged remote prefixes when the local stack has rebased them away.
GitHub owns PR base refs after linking. Preflight divergent orders before pushing, omit redundant base updates, and require users to unstack before a destructive reorder. Stack API failures remain best-effort so repositories outside the private preview preserve existing direct-mode behavior. Stack IDs are rediscovered rather than persisted to keep ghstack stateless.
Test Plan:
Live-tested with draft
[skip ci]PRs #190128 and #190129 in pytorch/pytorch. Verified native stack creation and ghstack-style updates, then dissolved the stack, closed the PRs, deleted the branches, and confirmed zero check runs.Authored with assistance from OpenAI Codex.