Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benedict/dicts/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def __deepcopy__(self, memo: dict[int, Any]) -> Self:
keypath_separator=self._keypath_separator,
)
for key, value in self.items():
obj[key] = _clone(value, memo=memo)
obj[_clone(key, memo=memo)] = _clone(value, memo=memo)
if self._frozen:
obj.freeze()
return obj
Expand Down
2 changes: 1 addition & 1 deletion benedict/dicts/base/base_dict.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def __contains__(self, o: object) -> bool:
def __deepcopy__(self, memo: dict[int, Any]) -> Self:
obj = self.__class__()
for key, value in self.items():
obj[key] = _clone(value, memo=memo)
obj[_clone(key, memo=memo)] = _clone(value, memo=memo)
if self._frozen:
obj.freeze()
return obj
Expand Down
61 changes: 61 additions & 0 deletions tests/dicts/test_deepcopy_keys.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
from __future__ import annotations

import copy
import unittest

from benedict import benedict
from benedict.dicts.base import BaseDict


class deepcopy_keys_test_case(unittest.TestCase):
def test_base_deepcopy_custom_keys(self) -> None:
class Key:
def __init__(self) -> None:
self.values: list[int] = []

for wrapped in (False, True):
for frozen in (False, True):
with self.subTest(wrapped=wrapped, frozen=frozen):
key = Key()
source = {key: [key]}
original = BaseDict(source) if wrapped else BaseDict()
if not wrapped:
original[key] = source[key]
if frozen:
original.freeze()
cloned = copy.deepcopy(original)
cloned_key = next(iter(cloned))
self.assertIsNot(cloned_key, key)
self.assertIs(cloned[cloned_key][0], cloned_key)
self.assertEqual(cloned.frozen, frozen)
cloned_key.values.append(1)
self.assertEqual(key.values, [])
self.assertIs(next(iter(original)), key)

def test_benedict_deepcopy_custom_keys(self) -> None:
class Key:
def __init__(self) -> None:
self.values: list[int] = []

for separator in (None, "/"):
for frozen in (False, True):
with self.subTest(separator=separator, frozen=frozen):
key = Key()
original = benedict(
{key: [key]},
keypath_separator=separator,
keyattr_enabled=False,
keyattr_dynamic=True,
)
if frozen:
original.freeze()
cloned = original.deepcopy()
cloned_key = next(iter(cloned))
self.assertIsNot(cloned_key, key)
self.assertIs(cloned[cloned_key][0], cloned_key)
self.assertEqual(cloned.frozen, frozen)
self.assertEqual(cloned.keypath_separator, separator)
self.assertFalse(cloned.keyattr_enabled)
self.assertTrue(cloned.keyattr_dynamic)
cloned_key.values.append(1)
self.assertEqual(key.values, [])