Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions benedict/dicts/keypath/keypath_dict.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,7 @@ def update(self, other: Any = (), /, **kwargs: Any) -> None:
keypath_util.check_keys(other, self._keypath_separator)
keypath_util.check_keys(kwargs, self._keypath_separator)
super().update(other, **kwargs)

def __ior__(self, other: Any) -> Self: # type: ignore[misc,override]
self.update(other)
return self
37 changes: 37 additions & 0 deletions tests/dicts/test_benedict.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,43 @@ def test_inplace_union_preserves_keypath_configuration(self) -> None:
self.assertEqual(b["item/name"], "new")
self.assertEqual(source, {"item": {"name": "new"}})

def test_inplace_union_validates_keypath_separator(self) -> None:
for use_pointer in (False, True):
with self.subTest(use_pointer=use_pointer):
source = {"existing": 1}
b = benedict(source) if use_pointer else benedict(existing=1)
original = b

b |= {"added": 2}
self.assertIs(b, original)
self.assertEqual(b, {"existing": 1, "added": 2})
if use_pointer:
self.assertEqual(source, {"existing": 1, "added": 2})

b |= {}
self.assertIs(b, original)
self.assertEqual(b, {"existing": 1, "added": 2})

with self.assertRaises(ValueError) as update_error:
b.update({"invalid.key": 3})
with self.assertRaises(ValueError) as union_error:
b |= {"invalid.key": 3}
self.assertEqual(
str(union_error.exception), str(update_error.exception)
)
self.assertEqual(b, {"existing": 1, "added": 2})
if use_pointer:
self.assertEqual(source, {"existing": 1, "added": 2})

for separator in ("/", None):
with self.subTest(separator=separator):
b = benedict(keypath_separator=separator)
original = b
b |= {"valid.key": 1}
self.assertIs(b, original)
self.assertEqual(list(dict.items(b)), [("valid.key", 1)])
self.assertEqual(b["valid.key"], 1)

def test_clean(self) -> None:
d = {
"a": {},
Expand Down
6 changes: 6 additions & 0 deletions tests/dicts/test_benedict_freeze.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ def test_freeze_prevents_setitem(self) -> None:
with self.assertRaises(TypeError):
b["b"] = 3

def test_freeze_prevents_inplace_union(self) -> None:
b = benedict({"a": 1}).freeze()
with self.assertRaisesRegex(TypeError, "frozen"):
b |= {"b": 2}
self.assertEqual(b, {"a": 1})

def test_freeze_prevents_setitem_keypath(self) -> None:
b = benedict({"a": {"b": 1}})
b.freeze()
Expand Down
Loading