Repository navigation
Preserve empty-string parent keys when flattening - #644
Open
UmutAlisoglu wants to merge 1 commit into
Open
UmutAlisoglu wants to merge 1 commit into
UmutAlisoglu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
An empty-string parent key is treated as the root prefix during flattening. This loses part of the path and can raise a false conflict:
Use
Noneas the internal root-prefix sentinel so an actual empty-string key still contributes a separator. Extend the existing falsy-parent tests and add a public round trip covering nested empty keys, indexed lists and custom separators. Source data stays unchanged.Related issue
No matching issue or PR found. This follows the falsy-parent fix in #600, whose scope explicitly left empty-string behavior unchanged. The reproduction above demonstrates the remaining case.
Validation
flatten.pyhas 100% line and branch coverage.Checklist before requesting a review
AI assistance: OpenAI Codex assisted with investigation, implementation, review and verification.