Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparisons can be asymmetric when one
benedictowns its contents and another wraps a dictionary. After the backing dictionary changes,owned == wrappedreads the wrapper's stale inherited dict storage, whilewrapped == ownedreads its current contents. Inequality has the same problem.Resolve a wrapped right-hand operand before delegating equality and inequality. The regression exercises
BaseDictand publicbenedict, both operand orders, changed/added/deleted keys and matching/nonmatching contents. Existing reflected-comparison tests continue to pass.Validation on Python 3.13 with the repository's test requirements: the baseline runs 990 tests successfully; the new regression fails in six subcases before the fix; all 991 tests pass afterward. Changed-file Ruff lint/format and full package mypy checks pass.
Disclosure: Codex produced this fix and description during a code audit and ran the checks locally. No production incident or human review is claimed.