Repository navigation
Release XLS and XLSX workbook resources when decoding fails - #648
Open
ShahadatTest wants to merge 1 commit into
Open
ShahadatTest wants to merge 1 commit into
ShahadatTest wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Selecting a missing worksheet or failing while reading a row exits XLSX decoding before
workbook.close()and VBA-archive cleanup. Legacy XLS decoding also never explicitly releases the workbook resources. Repeated failed imports can retain file/archive resources.Move existing XLSX cleanup into
finally, and release legacy workbook resources infinallyafter both successful and failed decoding. Original decoding errors still propagate. Tests cover invalid sheet names/indexes, row-reading errors and successful legacy decoding.Related issue
Independently reproduced; no matching open issue or PR found.
Validation
Five new cleanup assertions fail on the original implementation. Full Python 3.12 unittest suite: 994 passed. Focused XLS tests: 20 passed. Ruff lint/format, mypy on the changed module, and
git diff --checkpass.AI assistance
Prepared and tested with OpenAI Codex (GPT-6). Original user request:
new 14ta koro aro(make 14 more new contributions). Diff inspection was automated; no human review or personal production usage is claimed.