Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fix S3 output with both default and explicit client options. On current main,
to_json(filepath="s3://...")fails because the writer requiress3_options; supplying that keyword instead sends it to the JSON encoder and raises anotherTypeError.Remove the transport-only keyword before encoding and normalize omitted/None options to an empty mapping at S3 dispatch, matching the input path. Serializer options such as
indentandsort_keysstill reach the serializer, and the caller's options are preserved. The change adds no dependency or public method.Related issue
Fixes #649.
Validation
e910141: 13 errors across two test methods; fixed source: all 13 subcases pass.git diff --checkand independent agent review pass.No live AWS operations or full Python/OS matrix were run. Existing credential-gated S3 tests did not exercise AWS; the localhost upload checks use an isolated environment and disposable test values. The initial full test attempt needed the missing
orjsontest dependency; the completed 992-test run includes it.Checklist before requesting a review
AI assistance: OpenAI Codex investigated, implemented and tested this user-authorized contribution, including an independent agent review. No separate human review or personal production incident is claimed.