Repository navigation
Clean up S3 clients and upload files after transfer errors - #651
Open
ShahadatTest wants to merge 1 commit into
Open
ShahadatTest wants to merge 1 commit into
ShahadatTest wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Failed S3 downloads/uploads exit before closing the boto3 client. Failed uploads also leave their temporary file behind, including when client initialization or client cleanup fails.
Use
finallyfor client closure and upload-file cleanup. Tests simulate download/upload failures, client setup failures and a failing close method, without accessing AWS. Existing success-path I/O tests remain unchanged.Related issue
Independently reproduced; no matching open issue or PR found.
Validation
All four new tests fail on the original implementation. Python 3.12: 961 tests passed with 33 remote URL tests skipped in a local runner (no test-source changes). Focused I/O tests: 41 passed. Ruff lint/format, mypy on the changed module and
git diff --checkpass. The complete network-dependent run finished with three remote-URL error entries caused by DNS failures; it is not claimed as passing.AI assistance
Prepared and tested with OpenAI Codex (GPT-6). Original user request:
new 14ta koro aro(make 14 more new contributions). Diff inspection was automated; no human review or personal production usage is claimed.