feat: optional issuingdate for foreign birthplace encoding - #273
Draft
stefano-rossotti wants to merge 1 commit into
Draft
stefano-rossotti wants to merge 1 commit into
stefano-rossotti wants to merge 1 commit into
Conversation
For foreign countries (province EE), fiscal codes use the country code valid at first document issuance rather than at birth. Optional issuingdate on encode and encode_birthplace selects that code; Italian municipalities are unchanged. CLI adds --issuingdate for the encode subcommand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
issuingdatetoencode()andencode_birthplace().EE), the birthplace code is resolved usingissuingdatewhen provided; otherwise behavior is unchanged and usesbirthdate.birthdatefor birthplace lookup.encodesubcommand accepts--issuingdate.issuingdateparses and is not beforebirthdate.Motivation
Italian fiscal codes for people born abroad use the ISTAT country code assigned at first document issuance, not the code valid on the date of birth. Country codes change over time (e.g. Georgia:
Z136until 1994, thenZ254).Test plan
pytest(65 tests)Z136at birth vsZ254withissuingdate=01/01/2000issuingdateis set--issuingdateintegration test