Skip to content

Fix sticky unresolvable __all__ state - #4629

Open
tkim602 wants to merge 1 commit into
facebook:mainfrom
tkim602:fix/dunder-all-unresolvable-sticky
Open

Fix sticky unresolvable __all__ state#4629
tkim602 wants to merge 1 commit into
facebook:mainfrom
tkim602:fix/dunder-all-unresolvable-sticky

Conversation

@tkim602

@tkim602 tkim602 commented Aug 22, 2026

Copy link
Copy Markdown

Summary

Fixes #4563

keep an unresolvable __all__ state from being reset by later mutations and preserve DunderAllKind::Unresolvable across subsequent append, extend, and remove calls so star imports continue to use the fallback behavior.

Test Plan

Added regression coverage for:

  • keeping DunderAllKind::Unresolvable sticky across later __all__ mutations
  • preserving star-import fallback behavior after an unresolvable append

Ran:

cargo test test_all_unresolvable_is_sticky_across_mutations -- --nocapture
cargo test test_all_ -- --nocapture
cargo fmt --check
git diff --check

@meta-cla

meta-cla Bot commented Aug 22, 2026

Copy link
Copy Markdown

Hi @tkim602!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla

meta-cla Bot commented Aug 22, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unresolvable __all__ is not "sticky"

2 participants