Prerelease - #150
Open
summitt wants to merge 2 commits into
Open
Prerelease#150summitt wants to merge 2 commits into
summitt wants to merge 2 commits into
Conversation
The peer review view (TrackChanges, prqueue=true) renders each field into a suneditor rich-text editor, which reads the textarea value and injects it as innerHTML. Output-encoding the textarea does not help there, so any stored HTML in the "notes" fields executed in a reviewer's browser. Sanitize desc_notes/rec_notes/detail_notes on Vulnerability and summary1_notes/summary2_notes on Comment, matching the existing description/recommendation/details handling. Comment.exportAssessment rebuilds each vulnerability through these setters on every display, so this also neutralizes notes stored before the fix. Track-changes markup is preserved. Adds NotesXssSanitizationTest and bumps the version to 1.8.14-SNAPSHOT.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (app == null || file_data == null) { | ||
| return this.errorJson("Extension not found or no file uploaded"); | ||
| } | ||
| try (FileInputStream fis = new FileInputStream(file_data)) { |
| } | ||
| AppStore preview = new AppStore(); | ||
| preview.parseJar(fis); | ||
| try (FileInputStream fis = new FileInputStream(file_data)) { |
| return cipher.doFinal(ciphertext); | ||
| } | ||
| // Legacy AES/ECB value written by an earlier release. Read-only. | ||
| Cipher cipher = Cipher.getInstance("AES/ECB/PKCS5Padding"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.