fix(orm): resolve basedpyright errors in migration and make commands - #238
Merged
Merged
Conversation
handle() now declares -> int and returns 0 explicitly (cleo already mapped None to 0), and resolve_migration_path() returns str as annotated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch 14 of basedpyright fixes, scoped to
masoniteorm/commands/(no overlap with #237, #236, #170, #196, #220, #222).Changes (10 files)
handle()in DBMigrate, DBSeed, MigrateFresh/Refresh/Reset/Rollback/Status, MakeMigration, MakeModel, MakeSeed now declares-> intand returns0explicitly (fixesreportIncompatibleMethodOverrideagainst cleo'sCommand.handle() -> int).resolve_migration_path()wrapsuse_base_path()(aPath) instr()to match its-> strannotation.Migratoralready callsstr()/os.pathon it, so this changes nothing.Behaviour
None. Cleo's
BaseCommand.runalready maps aNonereturn to exit code0, so returning0explicitly keeps every exit code the same.MakeSeedCommandused toreturn self.line(...)(which isNone). It now callsself.line(...)and thenreturn 0.Verification
pytest --ignore=tests/masoniteorm/postgres: 2411 passed, 7 skippedNot covered here:
ShellCommand,MakeModelDocstringCommand(brokenload_configimport) andMakeObserverCommand.🤖 Generated with Claude Code