Repository navigation
Fix basedpyright provider-signature cascade - #255
Merged
Merged
Conversation
Provider.provider_key is now always str (empty default, inferred when falsy) so merge_config_from receives a str, and publishes accepts str | Path source keys.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root-level fix in
support/providers/provider.pyfor the 8reportArgumentTypeerrors caused by the Provider signatures after #241. No call-site changes.provider_key: str = ""(wasstr | None = None); key is inferred from the class name when falsy. Fixes 5xmerge_config_from(..., self.provider_key)(ai, fastapi, logging, database, vite).publishes(resources: dict[str | Path, str])(wasdict[str, Any]). Fixes 3xdict[Path, str]call sites (logging, database, storage provider).Behaviour change (edge case)
A subclass that explicitly sets
provider_key = ""now gets an inferred key instead of keeping"". No provider in the codebase does this. Covered by a new test.Verification
pytest --ignore=tests/masoniteorm/postgres: 2476 passed, 6 skippedruff check: cleanuv.lockuntouched; no overlap with Fix artisan serve crash: make uvicorn WebSocket backend configurable #211/Fix get_files(directory) on the S3 and local storage drivers #220/Fix get_files(directory) on S3 and local storage drivers #222