Conversation
change_format ran on every log call, stripped every handler from the root logger without closing it, and opened a fresh FileHandler, leaking one file descriptor per call. The driver now logs through a dedicated non-propagating logger per file that owns a single reused FileHandler; change_format only swaps the formatter on it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2098.
Root cause
LogSingleDriver.change_format()ran on every log call. It removed every handler fromlogging.getLogger("root")(which is the root logger) without closing them, then opened a newlogging.FileHandler. Each log call leaked one open file descriptor, and long-running servers eventually hit the OS open-file limit.Fix
fastapi_startkit.logging.single.<abspath>) that owns exactly oneFileHandler.change_format()only swaps the formatter on the existing handler. Format changes still apply.close()removes and closes the handler.LogSingleDriver, so the fix covers them too. Syslog doesn't create handlers per call and is left unchanged.Behaviour changes
LoggingHandlerbridge and any user or pytest handlers stay attached.setLevel()on the root logger. Its own logger is fixed at DEBUG, and the channelmax_levelstill filters.Tests
/dev/fd) unchanged.LoggingHandler) and its level are unchanged after logging.change_formatkeeps the same handler and applies the new format.close()releases one FD.--ignore=tests/masoniteorm/postgres: 2486 passed).LogSingleDriver.pyhas 100% coverage. ruff is clean, basedpyright reports 0 errors.🤖 Generated with Claude Code