GPU (Windows): preserves the generic basic display adapter label - #2571
Open
vzer200 wants to merge 1 commit into
Open
GPU (Windows): preserves the generic basic display adapter label#2571vzer200 wants to merge 1 commit into
vzer200 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid prefixing the generic
Microsoft Basic Display Adapterlabel with the physical GPU vendor in default output. For the data in the issue, the displayed name becomesMicrosoft Basic Display Adapterinstead ofNVIDIA Microsoft Basic Display Adapter.Related issue (required for new logos for new distros)
Fixes #2339.
Changes
Screenshots
Text output comparison using the issue's GPU data as a fixture:
The fixture fails before the fix and passes afterward. It does not depend on changing GPU drivers.
Validation
Built on Windows with LLVM-MinGW (Clang 23), CMake 4.4.3 and Ninja. All seven CTest executables passed, including the nine GPU fixtures. Full-repository codespell, formatting of changed code, and
git diff --checkpassed. Default JSON output parsed successfully (29 module results), and the all-module preset exited successfully. Optional dependencies unavailable on this machine followed normal CMake feature detection.AI-assisted implementation, independently reviewed by a second coding agent.
Checklist