Skip to content

GPU (Windows): preserves the generic basic display adapter label - #2571

Open
vzer200 wants to merge 1 commit into
fastfetch-cli:devfrom
vzer200:fix/basic-display-adapter-label
Open

GPU (Windows): preserves the generic basic display adapter label#2571
vzer200 wants to merge 1 commit into
fastfetch-cli:devfrom
vzer200:fix/basic-display-adapter-label

Conversation

@vzer200

@vzer200 vzer200 commented Sep 8, 2026

Copy link
Copy Markdown

Summary

Avoid prefixing the generic Microsoft Basic Display Adapter label with the physical GPU vendor in default output. For the data in the issue, the displayed name becomes Microsoft Basic Display Adapter instead of NVIDIA Microsoft Basic Display Adapter.

Related issue (required for new logos for new distros)

Fixes #2339.

Changes

  • Keep detected vendor/name data intact for JSON output and custom formats; apply the exact-name exception only when assembling the default display name.
  • Extract that small formatter for a driver-independent regression test. Nine cases cover the generic label with NVIDIA/AMD/Intel/Microsoft/empty vendors, normal GPU names, existing case-insensitive prefixes, and preservation of detected values.
  • Add an unreleased changelog entry.

Screenshots

Text output comparison using the issue's GPU data as a fixture:

Before: NVIDIA Microsoft Basic Display Adapter
After:  Microsoft Basic Display Adapter

The fixture fails before the fix and passes afterward. It does not depend on changing GPU drivers.

Validation

Built on Windows with LLVM-MinGW (Clang 23), CMake 4.4.3 and Ninja. All seven CTest executables passed, including the nine GPU fixtures. Full-repository codespell, formatting of changed code, and git diff --check passed. Default JSON output parsed successfully (29 module results), and the all-module preset exited successfully. Optional dependencies unavailable on this machine followed normal CMake feature detection.

AI-assisted implementation, independently reviewed by a second coding agent.

Checklist

  • I have tested my changes locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Microsoft Basic Display Adapter not appearing properly when GPU is installed without drivers.

1 participant