Skip to content

fix(tokenizer): drop unfinished tags after a closing tag name or slash at EOF #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yxshee wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(tokenizer): drop unfinished tags after a closing tag name or slash at EOF #2568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adbc049
fix(tokenizer): drop unfinished tags after a closing tag name or slas…
yxshee Nov 9, 2026
db1230d
test(tokenizer): check every chunk split for unfinished tags at EOF
yxshee Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/Tokenizer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,21 @@ describe("Tokenizer", () => {
expect(tokenize("</>")).toMatchSnapshot();
});

it.each(["a</b ", "a<b /"])(
"should not emit text for an unfinished tag at EOF for %s",
(input) => {
for (let split = 0; split <= input.length; split++) {
expect(
tokenize((tokenizer) => {
tokenizer.write(input.slice(0, split));
tokenizer.write(input.slice(split));
tokenizer.end();
}).filter(([event]) => event === "ontext"),
).toEqual([["ontext", 0, 1]]);
}
},
);

it("should treat <!DOCTYPEhtml> as a declaration", () => {
expect(tokenize("<!DOCTYPEhtml>")).toMatchSnapshot();
});
Expand Down
4 changes: 3 additions & 1 deletion src/Tokenizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1114,7 +1114,9 @@ export default class Tokenizer {
case State.InAttributeValueSq:
case State.InAttributeValueDq:
case State.InAttributeValueNq:
case State.InClosingTagName: {
case State.InSelfClosingTag:
case State.InClosingTagName:
case State.AfterClosingTagName: {
/*
* If we are currently in an opening or closing tag, us not calling the
* respective callback signals that the tag should be ignored.
Expand Down
Loading