Repository navigation
fix(dash): save email check authentication options on edit - #864
Merged
Merged
Conversation
…solidping-business#73) Changing the SPF/DKIM/DMARC/blocklist options of an existing email check was silently dropped: check-form.tsx omitted `config` from the PATCH of every passive check, so only heartbeat/private-location (nothing editable) should skip it. Email edits now send their config; the stored token rides along in the passthrough and the server preserves an absent one anyway. New Playwright test edits an existing email check and asserts the options and the unchanged token; it failed before the fix (require_spf undefined). Closes fclairamb/solidping-business#73 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fclairamb
added
autopilot
frozen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #862: merge it first.
Editing an email check dropped its config from the save request, so the sender authentication options (SPF, DKIM, DMARC, blocklists) were never saved. Email checks now send their config; heartbeat and private-location are unchanged. Browser e2e test added.
Closes fclairamb/solidping-business#73
Decided by autopilot
None.
🤖 Generated with Claude Code