Repository navigation
fix: sftp handshake timeout, browser page detached logs, html lang follows i18n - #866
Merged
Merged
Conversation
…es read as such (fclairamb/solidping-business#74) A stalled SFTP server (TCP accepted, then silence) held the checker in the SSH handshake past the worker deadline, so the worker abandoned it: the pre-dialed conn had no deadline (checksftp/checker.go, ssh.NewClientConn). The conn is now closed via context.AfterFunc, and ctx-caused session/Stat failures report StatusTimeout. TestExecute_HonorsContextOnAStalledServer hung before the fix. A browser screenshot whose page closed or crashed first (CDP -32000 "Not attached to an active page") was logged as a WARN capture failure with the raw protocol error. It now logs at INFO with page_detached=true and the diagnostics say "the page was closed or crashed before the capture" (TestCaptureErrorMessageNamesADetachedPage, did not compile before). Closes fclairamb/solidping-business#74 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…/solidping-business#75) A visitor whose browser language the dashboard ships (es, fr, de) got the page rendered in that language under the static lang="en" of index.html, so the browser offered to auto-translate it; the translator's DOM edits then crashed React's reconciliation (removeChild NotFoundError) on the login page. i18n.ts now sets document.documentElement.lang to i18n.resolvedLanguage on every language change. src/i18n-html-lang.test.ts failed before the fix. Closes fclairamb/solidping-business#75 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fclairamb
added
autopilot
frozen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #862: merge it first.
Closes fclairamb/solidping-business#74
Closes fclairamb/solidping-business#75
<html lang>follows displayed language (fixes browser auto-translate crash)🤖 Generated with Claude Code