Repository navigation
fix(dash0): an email check's SPF, DKIM, DMARC and blocklist options can now be changed on its edit page - #868
Merged
Conversation
The edit form dropped config from every passive check's PATCH, so the SPF, DKIM, DMARC and blocklist options showed on edit but never saved. Email now sends its config; the server keeps the stored inbound token. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #868 +/- ##
==========================================
+ Coverage 90.66% 90.69% +0.02%
==========================================
Files 1362 1362
Lines 140091 140091
==========================================
+ Hits 127017 127051 +34
+ Misses 13065 13031 -34
Partials 9 9 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
#854 added the sender-authentication options (
require_spf,require_dkim,require_dmarc,check_blocklists,blocklists) to the email check form. The edit page shows them, loaded from the stored config. But the shared check form dropsconfigfrom the PATCH of every passive check type on edit (it was written when the only passive config was the server-managed token). So the options showed, the save returned 200, and nothing was stored.Fix
check-form.tsx: an email check's edit PATCH now carries its config. Heartbeat and private-location edits still omit it (no editable key, and a read-only region).preserveAbsentRedactedFields), so the address does not change.Tests
TestPatchingEmailAuthOptionsKeepsTheTokenpatches the options in, checks they are stored and the token survives, then clears them with an empty config.email-check-sender-auth.spec.tsnow edits an existing email check, turns every option on, reloads the edit form, turns them off, and asserts the stored config and token after each save. Run against a side-car server: 2/2 passed.golangci-lint0 issues, dash0 unit tests 2911 passed,lint:e2eandtypecheck:e2eclean. The unscoped dash0 lint is red on base, unchanged here.🤖 Generated with Claude Code