Skip to content

fix(dash0): an email check's SPF, DKIM, DMARC and blocklist options can now be changed on its edit page - #868

Merged
fclairamb merged 1 commit into
mainfrom
claude/fix-check-edit-email-auth-1dd459
Nov 13, 2026
Merged

fclairamb merged 1 commit into
mainfrom
claude/fix-check-edit-email-auth-1dd459

Conversation

@fclairamb

Copy link
Copy Markdown
Owner

Root cause

#854 added the sender-authentication options (require_spf, require_dkim, require_dmarc, check_blocklists, blocklists) to the email check form. The edit page shows them, loaded from the stored config. But the shared check form drops config from the PATCH of every passive check type on edit (it was written when the only passive config was the server-managed token). So the options showed, the save returned 200, and nothing was stored.

Fix

  • check-form.tsx: an email check's edit PATCH now carries its config. Heartbeat and private-location edits still omit it (no editable key, and a read-only region).
  • The server already keeps the stored inbound token when a PATCH leaves it out (preserveAbsentRedactedFields), so the address does not change.

Tests

  • Backend: TestPatchingEmailAuthOptionsKeepsTheToken patches the options in, checks they are stored and the token survives, then clears them with an empty config.
  • E2E: email-check-sender-auth.spec.ts now edits an existing email check, turns every option on, reloads the edit form, turns them off, and asserts the stored config and token after each save. Run against a side-car server: 2/2 passed.
  • golangci-lint 0 issues, dash0 unit tests 2911 passed, lint:e2e and typecheck:e2e clean. The unscoped dash0 lint is red on base, unchanged here.

🤖 Generated with Claude Code

The edit form dropped config from every passive check's PATCH, so the SPF,
DKIM, DMARC and blocklist options showed on edit but never saved. Email
now sends its config; the server keeps the stored inbound token.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.69%. Comparing base (2bce978) to head (0ceb1fb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #868      +/-   ##
==========================================
+ Coverage   90.66%   90.69%   +0.02%     
==========================================
  Files        1362     1362              
  Lines      140091   140091              
==========================================
+ Hits       127017   127051      +34     
+ Misses      13065    13031      -34     
  Partials        9        9              

see 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fclairamb
fclairamb enabled auto-merge (squash) November 13, 2026 10:05
@fclairamb
fclairamb merged commit 612be13 into main Nov 13, 2026
38 checks passed
@fclairamb
fclairamb deleted the claude/fix-check-edit-email-auth-1dd459 branch November 13, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant