fix: Preserve request source schema additions and removals - #6823
Open
Arnavsharma2 wants to merge 3 commits into
Open
Arnavsharma2 wants to merge 3 commits into
Arnavsharma2 wants to merge 3 commits into
Conversation
Signed-off-by: Arnav Sharma <73969466+Arnavsharma2@users.noreply.github.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6823 +/- ##
==========================================
+ Coverage 47.11% 47.18% +0.06%
==========================================
Files 419 419
Lines 51886 51883 -3
Branches 7528 7526 -2
==========================================
+ Hits 24448 24480 +32
+ Misses 25688 25656 -32
+ Partials 1750 1747 -3
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
RequestSource.__eq__compares schemas withzip, so schemas with the same prefix but different lengths compare equal. File and SQL registries then silently skip the update duringFeatureStore.apply().Compare the complete schema lists so added and removed fields are persisted. Existing field-order, field-value, and source-metadata comparisons are preserved.
Which issue(s) this PR fixes:
No existing issue.
Checks
git commit -s).Tests
Ran and passed 90 unit tests across data sources, FeatureStore, file/SQL registries, on-demand feature views, and registry diffs.
The added regressions produced 10 failures and 6 passes before the fix.
Misc
AI assistance: Investigated and helped implement this change.
Release note: Request source schema additions and removals are now persisted when reapplied to file and SQL registries.