Cbf fix block fetch (rebased)#35
Merged
Merged
Conversation
Previously we did not track the `FiltersSynced` kyoto event, so we could not tell when we had applied all blocks up to the tip. For example, when we stop and restart the node, kyoto's tip is 0 at the instant of start (it does not persist its chain), so our applied height trivially matches kyoto's tip and we would falsely conclude we had reached it. That is only actually true once we have received `FiltersSynced`.
Now the function is called `list_watched_scripts`.
Previously stalled fetch would hang indefinitely. AI-assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #34 after the
cbf-chain-source-cleanupstack was rebased onto the currentmain. The original contributor fork could not be updated with maintainer credentials, so the four head-only commits were replayed onto the cleaned-up base and published from this repository.What changed
All four commits retain Alexander Shevtsov as their Git author. The committer records reflect the rebase operation.
Validation
cargo fmt --allcargo checkcargo test --lib(78 passed)AI tool disclosure
OpenAI Codex performed the rebase, formatting, validation, and pull-request preparation. The original implementation authorship is preserved.