Repository navigation
Fix simcheck source and portable interpolation checks - #33
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot attempts to resolve the statistical Git dependency as simcheck==0.2.0 from PyPI, where that name belongs to an unrelated robotics package. Declare the existing Git source in tool.uv.sources so Dependabot excludes it from registry updates and uv preserves the intended source. The locked Git commit is unchanged.
Validated locally with the full test suite, strict Preen, lint/type checks, documentation, distribution build, and installed-wheel tests. Both project resolution and the wheel installation select finite-sample/simcheck. The source handling was checked against Dependabot’s parser.
Related: gojiplus/py-canon#108.
Local macOS testing also reproduced 75 interpolation-test failures: NumPy can fuse its multiply-add while the vectorized grid kernel rounds twice. Keep exact bin and knot checks, but enforce a one-ULP interpolation bound instead of bit identity and correct the internal documentation. A 771,858-point probe measured a maximum difference of one ULP; a math.fma probe exactly matched NumPy. The full suite passes locally, and kernel tests pass on Python 3.12, 3.13, and 3.14. No runtime algorithm changes.