Skip to content

fix(auth): resolve IdTokenListener Kotlin compile failure in CI#2380

Merged
russellwheatley merged 2 commits into
masterfrom
version-10.0.0-beta03
Jul 9, 2026
Merged

fix(auth): resolve IdTokenListener Kotlin compile failure in CI#2380
russellwheatley merged 2 commits into
masterfrom
version-10.0.0-beta03

Conversation

@demolaf

@demolaf demolaf commented Jul 9, 2026

Copy link
Copy Markdown
Member

Fixes IdTokenListener CI compile failure by removing the redundant push trigger and giving the listener lambda an explicit FirebaseAuth type so Kotlin doesn't need to resolve Firebase's internal (unpublished) Checker Framework annotation.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@demolaf demolaf changed the title chore(ci): remove redundant push trigger from e2e_test.yml fix(auth): resolve IdTokenListener Kotlin compile failure in CI Jul 9, 2026
@demolaf

demolaf commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

/gemini review

@demolaf demolaf requested a review from russellwheatley July 9, 2026 11:59

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request explicitly specifies the FirebaseAuth type for the firebaseAuth lambda parameter in IdTokenListener within FirebaseAuthUI.kt. There are no review comments, and I have no feedback to provide.

@russellwheatley russellwheatley merged commit af90f88 into master Jul 9, 2026
18 checks passed
@russellwheatley russellwheatley deleted the version-10.0.0-beta03 branch July 9, 2026 12:35
@github-project-automation github-project-automation Bot moved this from Backlog to Done in studio-2394994192-60a69 Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants