Repository navigation
Version 10.0.1 - #2553
Open
demolaf wants to merge 6 commits into
Open
Version 10.0.1#2553demolaf wants to merge 6 commits into
demolaf wants to merge 6 commits into
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
demolaf
force-pushed
the
version-10.0.1
branch
from
November 5, 2026 14:59
d12d750 to
6ef40db
Compare
…k mode to the full customization demo (#2545)
demolaf
force-pushed
the
version-10.0.1
branch
from
November 5, 2026 15:00
6ef40db to
4b004cb
Compare
…il provider (#2551) * fix(auth): offer no email recovery for account linking without an Email provider The account-linking dialog's recover action always opened the email sign-in step. With no AuthProvider.Email configured, EmailAuthScreen called .first() on an empty provider list and crashed. Gate the recover action on an Email provider being configured (not on sign-up being offered, since linking signs in to an existing account), and make EmailAuthScreen render nothing instead of throwing when a host routes to it without one. * fix(auth): report a missing Email provider and guard the address-in-use recovery - EmailAuthScreen reports a MisconfigurationException through onError and leaves the step, instead of returning silently to an empty step. - EmailAlreadyInUseException offers no email recovery without an Email provider, matching account linking. - SignUpUI and SignInEmailLinkUI no longer call first() on the Email provider.
…hat owns the address (#2564) * fix(auth): link a colliding provider credential through the account that owns the address - The account-linking recovery opens the provider that owns the address: the opt-in legacy lookup names it when it can, a lone remaining provider is opened directly, and several are offered on the method picker. - Google, Facebook and OAuth sign-ins link the pending credential before reporting success, and only to an account with the same address; a mismatch or a failed link signs back out instead of half-finishing. - Account-linking errors carry the translated recovery message instead of hard-coded English. * fix(auth): refuse an email-step sign-in at another address while a link is pending The account-linking recovery prefills the account's address, but the field stays editable. Signing in elsewhere would link the credential to someone else, so the email step now refuses before signing in, as the provider flows do after. * fix(auth): keep the account-linking recovery all or nothing on every path - Only a sign-in through a provider the recovery offered finishes the link; any other, such as phone, drops it instead of being refused. - A mismatched account the sign-in only just created is deleted rather than left behind; a cancelled link signs back out. - The email step links the recovery's credential all or nothing, and the email-link step is held to the account's address too. - The provider credential a collision saved for a later email-link sign-in is forgotten once the recovery's link ends. * fix(auth): close the remaining gaps in the account-linking recovery - A mismatch undone while cancelled still signs out. - An email-link sign-in counts as the Email provider, so it finishes the recovery's link instead of dropping it. - A linking error with no credential keeps the link already pending. - The credential saved for email-link sign-in is forgotten where the link resolves, not only from the screen. - No provider recovery when the collision names no address. - The email step merges the linked provider's profile again. * fix(auth): keep the account-linking recovery through recreation, lookups and auto-select - The pending link is saveable, so an Activity recreated while the owner's sign-in UI is open still finishes the link. - The opt-in owner lookup shows loading, so no second sign-in can start while it runs. - Google auto-select is off while a link is pending, so a wrong pick is not handed back again. * docs(auth): restore the getStartRoute KDoc above its function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes