WIP feat(messaging): add support for Android Config V2#3205
Draft
jonathanedey wants to merge 3 commits into
Draft
WIP feat(messaging): add support for Android Config V2#3205jonathanedey wants to merge 3 commits into
jonathanedey wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the Android V2 configuration (androidV2) for Firebase Cloud Messaging (FCM) payloads, supporting remote notifications and background sync. It includes new TypeScript interfaces, validation logic, and comprehensive unit tests. The feedback suggests refactoring the validateAndroidConfigV2 function to use the existing renameProperties utility for renaming remoteNotification and backgroundSync properties, which would improve consistency and simplify the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
androidV2property toBaseMessageandMulticastMessageinterfacesAndroidConfigV2,AndroidRemoteNotificationConfig, andAndroidBackgroundSyncConfigtypesandroidV2properties, including nestedremoteNotificationandbackgroundSyncexclusivity constraintsandroidand newandroidV2payload configurationsandroidV2property serialization, types, and error constraints