Skip to content

WIP feat(messaging): add support for Android Config V2#3205

Draft
jonathanedey wants to merge 3 commits into
mainfrom
je-fcm-v2
Draft

WIP feat(messaging): add support for Android Config V2#3205
jonathanedey wants to merge 3 commits into
mainfrom
je-fcm-v2

Conversation

@jonathanedey

Copy link
Copy Markdown
Contributor
  • Add androidV2 property to BaseMessage and MulticastMessage interfaces
  • Introduce AndroidConfigV2, AndroidRemoteNotificationConfig, and AndroidBackgroundSyncConfig types
  • Implement validation for androidV2 properties, including nested remoteNotification and backgroundSync exclusivity constraints
  • Enforce mutual exclusivity between legacy android and new androidV2 payload configurations
  • Add unit tests validating androidV2 property serialization, types, and error constraints
  • Export new V2 interfaces

@jonathanedey jonathanedey marked this pull request as draft July 6, 2026 17:53

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the Android V2 configuration (androidV2) for Firebase Cloud Messaging (FCM) payloads, supporting remote notifications and background sync. It includes new TypeScript interfaces, validation logic, and comprehensive unit tests. The feedback suggests refactoring the validateAndroidConfigV2 function to use the existing renameProperties utility for renaming remoteNotification and backgroundSync properties, which would improve consistency and simplify the code.

Comment thread src/messaging/messaging-internal.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant