fix(appcheck): Use v1beta endpoint for verifyAppCheckToken - #987
Conversation
Updated _AppCheckService._VERIFY_URL_FORMAT to point to the v1beta endpoint (https://firebaseappcheck.googleapis.com/v1beta/projects/{project_id}:verifyAppCheckToken) for replay protection verification.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the App Check verification URL format from 'v1' to 'v1beta' in firebase_admin/app_check.py and updates the corresponding unit tests in tests/test_app_check.py to reflect this change. There are no review comments, and the changes appear to be correct and complete.
|
Also I want to confirm that the PR title should be feat(appcheck) or feat(fac) for the appcheck team related matters? Cause I saw a mix use of both |
These were used by a previous release note generation tool that we no longer use, so it doesn't matter much. Either prefix is fine, but let's stick with "appcheck" moving forward for consistency :) |
lahirumaramba
changed the title
2 participants
Regression from #976
Updated
_AppCheckService._VERIFY_URL_FORMATinfirebase_admin/app_check.pyto use thev1betaendpoint (https://firebaseappcheck.googleapis.com/v1beta/projects/{project_id}:verifyAppCheckToken) when verifying token replay protection (consume=True), asverifyAppCheckTokenis publicly exposed underv1beta.