Fix Issue #1902: Explicitly set CMAKE_OSX_DEPLOYMENT_TARGET to 15.0 - #1903
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request sets the minimum deployment target (CMAKE_OSX_DEPLOYMENT_TARGET) to 15.0 across iOS and tvOS build scripts, CMake configurations, and test scripts to resolve linker warnings. The reviewer suggests allowing this target to be overridden via the CMAKE_OSX_DEPLOYMENT_TARGET environment variable (defaulting to 15.0) in the build and GHA scripts to maintain flexibility for custom builds.
AustinBenoit
added
the
tests-requested: quick
github-actions
Bot
added
tests: in-progress
❌ Integration test FAILEDRequested by @AustinBenoit on commit cee15b7
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
Bot
removed
the
tests: in-progress
Fix Issue #1902: Explicitly set CMAKE_OSX_DEPLOYMENT_TARGET to 15.0
AustinBenoit
marked this pull request as ready for review
August 11, 2026 21:46
a-maurice
approved these changes
Aug 11, 2026
AustinBenoit
added
tests: succeeded
Contributor
Author
|
Tests not related to the change are failing |
AustinBenoit
enabled auto-merge (squash)
August 11, 2026 23:18
github-actions
Bot
added
tests: in-progress
firebase-workflow-trigger
Bot
removed
the
tests: in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Explicitly set CMAKE_OSX_DEPLOYMENT_TARGET to 15.0 the minimum supported iOS version
Testing
Trigger integration tests plus pull down the built packages and make sure I don't get any warning.
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.