Skip to content

Disable new Messaging test on Desktop and Emulator - #1906

Merged
a-maurice merged 1 commit into
mainfrom
am-messaging_fix
Aug 10, 2026
Merged

Disable new Messaging test on Desktop and Emulator#1906
a-maurice merged 1 commit into
mainfrom
am-messaging_fix

Conversation

@a-maurice

Copy link
Copy Markdown
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Disable the new Messaging test on Desktop and Android Emulator. The functionality is stubbed out on Desktop, and Android Emulators behave differently. This is inline with most other tests in the file. Also, moving the readme line to upcoming.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice
a-maurice requested a review from AustinBenoit August 10, 2026 21:32

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the integration tests for Firebase Messaging to skip the TestRegisterAndUnregister test on desktop and Android emulator environments. Additionally, it modifies the release notes in readme.md by moving the entry about new Messaging registration methods from version 13.11.0 to a new 'Upcoming' section. There are no review comments, and I have no feedback to provide.

@a-maurice
a-maurice merged commit 403fd6a into main Aug 10, 2026
38 checks passed
@a-maurice
a-maurice deleted the am-messaging_fix branch August 10, 2026 23:44
@github-actions github-actions Bot added the tests: in-progress This PR's integration tests are in progress. label Aug 10, 2026
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

❌  Integration test FAILED

Requested by @a-maurice on commit 403fd6a
Last updated: Mon Aug 10 18:33 PDT 2026
View integration test log & download artifacts

Failures Configs
messaging [TEST] [FAILURE] [Linux] [x64] [openssl]
(1 failed tests)  FirebaseMessagingTest.TestRegistrationOnInitEnabled
[TEST] [FAILURE] [Windows] [x64] [openssl]
(1 failed tests)  FirebaseMessagingTest.TestRegistrationOnInitEnabled

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions Bot added the tests: failed This PR's integration tests failed. label Aug 11, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests: failed This PR's integration tests failed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants