Explicitly set curl to build statically

[a-maurice]

Description

Provide details of the change, and generalize the change in the PR title above.

Explicitly set CMake flags to make curl build as a static library. Note that this should effectively be a no-op, since these flags are set by the underlying iOS Firestore CMake logic, the problem only occurs when building without enabling Firestore.

---

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Building locally, and checking the resulting bundle symbols.

---

Type of Change

Place an x the applicable box:

• Bug fix. Add the issue # below if applicable.
• New feature. A non-breaking change which adds functionality.
• Other, such as a build process or documentation change.

---

Notes

• Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
• Read the contribution guidelines CONTRIBUTING.md.
• Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

[gemini-code-assist]

Code Review

This pull request configures curl to build as a static library by setting BUILD_SHARED_LIBS and BUILD_CURL_EXE to OFF in CMakeLists.txt. The reviewer suggested defining these as local variables instead of cache variables to prevent polluting the global cache and to ensure they take effect properly when the project is included as a subdirectory.

[a-maurice]

/gemini review

[gemini-code-assist]

Code Review

This pull request modifies the CMake configuration for desktop builds to build curl as a static library and disable building the curl executable. The review feedback points out that setting BUILD_SHARED_LIBS globally to OFF can leak to other subdirectories and external libraries, and recommends saving and restoring its original value to prevent unintended side effects.

[gemini-code-assist]

Setting BUILD_SHARED_LIBS globally to OFF will leak to all subsequent subdirectories and external libraries (such as libuv, zlib, and the Firebase SDK components themselves like app, analytics, etc.). This overrides any user-specified BUILD_SHARED_LIBS setting for the rest of the build.\n\nTo prevent this side effect, you should save the original value of BUILD_SHARED_LIBS before modifying it, and restore it immediately after add_external_library(curl) (around line 450).\n\nSince add_external_library(curl) is outside of this diff hunk, please apply the following pattern:\n\n1. Save the variable state here (using the code suggestion below).\n2. Restore it after add_external_library(curl):\ncmake\nif(DEFINED OLD_BUILD_SHARED_LIBS)\n set(BUILD_SHARED_LIBS ${OLD_BUILD_SHARED_LIBS})\nelse()\n unset(BUILD_SHARED_LIBS)\nendif()\n

  set(OLD_BUILD_SHARED_LIBS ${BUILD_SHARED_LIBS})\n  set(BUILD_SHARED_LIBS OFF)\n  set(BUILD_CURL_EXE OFF)\n  set(CURL_STATICLIB ON)

[a-maurice]

Firebase C++ expects the dependencies to be static, so this should have no issue.

[github-actions]

❌  Integration test FAILED

Requested by @a-maurice on commit 8715933
Last updated: Tue Aug 11 15:38 PDT 2026
View integration test log & download artifacts

Failures	Configs
missing_log	[BUILD] [ERROR] [iOS] [macos] [TEST] [ERROR] [Android] [All 3 os] [1/2 android_device: android_target]
messaging	[TEST] [FAILURE] [Linux] [x64] [openssl] (1 failed tests)   FirebaseMessagingTest.TestRegistrationOnInitEnabled [TEST] [FAILURE] [Windows] [x64] [openssl] (1 failed tests)   FirebaseMessagingTest.TestRegistrationOnInitEnabled

Add flaky tests to go/fpl-cpp-flake-tracker