ci: cache VS Code test executable in vscode_unit CI workflow - #11030
Open
joehan wants to merge 1 commit into
Open
ci: cache VS Code test executable in vscode_unit CI workflow#11030joehan wants to merge 1 commit into
joehan wants to merge 1 commit into
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Berlioz
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The VS Code unit tests in CI (
vscode_unit) currently download the ~130MB VS Code Electron archive fromupdate.code.visualstudio.comon every runner invocation. Transient CDN drops or socket terminations (such asECONNRESET) cause intermittent test flakes.This change adds an
actions/cachestep targetingfirebase-vscode/.vscode-test, keyed on the OS and the contents offirebase-vscode/src/test/constants.ts(whereVSCODE_VERSIONis defined), with a fallback restore key.Scenarios Tested