Skip to content

Bump version 0.1.6 - #70

Merged
huangjeff5 merged 2 commits into
mainfrom
bump-version-0.1.6
Aug 10, 2026
Merged

huangjeff5 merged 2 commits into
mainfrom
bump-version-0.1.6

Conversation

@huangjeff5

Copy link
Copy Markdown
Contributor

No description provided.

@huangjeff5
huangjeff5 merged commit 0685961 into main Aug 10, 2026
13 checks passed
@huangjeff5
huangjeff5 deleted the bump-version-0.1.6 branch August 10, 2026 14:01

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request attempts to upgrade the runtime to Node.js 22 and update dependencies. However, there are several inconsistencies: the runtime in extension.yaml and the engine requirement in functions/package.json were downgraded to Node.js 20/>=20 instead of being upgraded to Node.js 22, contradicting the changelog and package-lock.json. Additionally, typescript was incorrectly moved from devDependencies to production dependencies.

Comment thread extension.yaml
Comment thread functions/package.json
Comment thread functions/package.json
@huangjeff5

Copy link
Copy Markdown
Contributor Author

Thanks for the review @gemini-code-assist! Here is context on why these configurations are set as they are for Firebase Extensions publishing:

  1. Node.js Target (nodejs20): The official Firebase Extensions cloud builder environment (extensions-builder-prod) currently runs Node.js 20 (v20.4.0) and does not yet support nodejs22 runtime (publishing with nodejs22 causes the cloud build worker to fail with version v22 is not yet installed). I have updated CHANGELOG.md to accurately reference Node.js 20.

  2. TypeScript Dependency: The Firebase Extension builder performs a production-only npm install (--omit=dev) on the source repository. Because functions/package.json specifies "prepare": "tsc", tsc runs post-install during cloud assembly. If typescript and @types/node are strictly under devDependencies, the cloud build fails with sh: tsc: not found and TS2688: Cannot find type definition file for 'node'.

@gemini-code-assist

Copy link
Copy Markdown

Thanks for the detailed explanation, @huangjeff5. That makes perfect sense. Given the current constraints of the extensions-builder-prod environment and the way the Firebase Extension builder handles production-only npm install with the prepare script, moving typescript to dependencies is indeed the correct approach to ensure the build succeeds in that environment. Your changes to CHANGELOG.md and the runtime configuration are appropriate under these circumstances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant