Skip to content

Fix: Update dependencies for cloud builder and correct CHANGELOG to Node.js 20 - #71

Merged
huangjeff5 merged 3 commits into
mainfrom
fix-types-builder
Aug 10, 2026
Merged

huangjeff5 merged 3 commits into
mainfrom
fix-types-builder

Conversation

@huangjeff5

Copy link
Copy Markdown
Contributor

Summary

  • Node.js 20: Corrected CHANGELOG and runtime configurations to target Node.js 20 (since Node.js 22 is not yet supported in the environment).
  • Build Dependencies: Moved typescript, @types/node, and @types/jest into dependencies in functions/package.json so that production npm install on the Cloud Builder worker can successfully execute the prepare (tsc) build step.

Tested and verified publish with Firebase Extensions CLI.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CHANGELOG to specify Node.js 20, removes 'jest' from the TypeScript types configuration, and moves '@types/jest' and '@types/node' to production dependencies. The feedback recommends keeping '@types/jest' in 'devDependencies' to avoid unnecessarily bloating production dependencies, as it is no longer required for compiling production code.

Comment thread functions/package.json Outdated
@huangjeff5

Copy link
Copy Markdown
Contributor Author

Thanks @gemini-code-assist! Great spot. Now that tsconfig.json only targets ["node"], @types/jest is no longer needed for compiling production code.

I've moved @types/jest back to devDependencies in the latest commit while keeping typescript and @types/node in dependencies for the Cloud Builder's prepare step.

@gemini-code-assist

Copy link
Copy Markdown

That sounds like a solid plan. Keeping @types/jest in devDependencies while ensuring typescript and @types/node are available for the build process is the correct approach for maintaining a clean production dependency tree. Thanks for the update!

@huangjeff5
huangjeff5 merged commit 5774626 into main Aug 10, 2026
14 checks passed
@huangjeff5
huangjeff5 deleted the fix-types-builder branch August 10, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant