Fix: Update dependencies for cloud builder and correct CHANGELOG to Node.js 20 - #71
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the CHANGELOG to specify Node.js 20, removes 'jest' from the TypeScript types configuration, and moves '@types/jest' and '@types/node' to production dependencies. The feedback recommends keeping '@types/jest' in 'devDependencies' to avoid unnecessarily bloating production dependencies, as it is no longer required for compiling production code.
|
Thanks @gemini-code-assist! Great spot. Now that I've moved |
|
That sounds like a solid plan. Keeping |
Summary
typescript,@types/node, and@types/jestintodependenciesinfunctions/package.jsonso that productionnpm installon the Cloud Builder worker can successfully execute theprepare(tsc) build step.Tested and verified publish with Firebase Extensions CLI.