Repository navigation
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
No issues found across 10 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Bounded deletion of the hidden firecrawl create and firecrawl sql commands (with experimental sql/x sql aliases) and the vendored agent-scaffold utilities; no new behavior is introduced and SQL remains available via scrape --alexandria.
View guided diff | Turn on auto-fix | Re-trigger cubic
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes two commands that were registered but hidden from
firecrawl --help:firecrawl create(create agent), the starter-project scaffolder, together with everything only it used:src/commands/create.tsand the vendoredsrc/utils/agent-scaffold/(create flow, manifest, scaffold, credentials and UI helpers).firecrawl sqland itsfirecrawl experimental sql/firecrawl x sqlaliases:src/commands/sql.ts, its unit test, and its case incli-aliases.test.ts.The registrations in
src/index.tsgo with them. Theexperimentalgroup keepsdownload. No dependency becomes unused (@inquirer/promptsis still used elsewhere), and the README and skills never mentioned either command, so there is nothing to update there.The
firecrawl/sqlAlexandria capability itself is untouched: it is still reachable throughscrape --alexandria, so the SQL cost handling inreceipt.tsand its tests stay.1,438 lines deleted, none added.
Verification
pnpm run type-check,pnpm run format:checkandpnpm run buildpass.node dist/index.js --helpandfirecrawl x --helprender as before;firecrawl create ...andfirecrawl sql ...now fail withunknown command.cli-aliases.test.ts,receipt.test.tsandalexandria-beta.test.tspass locally (105 tests).Summary by cubic
Removes the hidden
firecrawl createandfirecrawl sqlcommands, together with theexperimental sql/x sqlaliases and the vendored agent-scaffold utilities they used.Notes
firecrawl create,firecrawl sql,firecrawl experimental sql, andfirecrawl x sqlnow fail withunknown command; theexperimentalgroup keepsdownload.firecrawl/sqlAlexandria capability is unchanged and still reachable viascrape --alexandria.Written for commit 084103c. Summary will update on new commits.