Skip to content

fix(setup): bump add-mcp to 2.6.1 to fix deep-merge config corruption - #387

Open
genius-0963 wants to merge 1 commit into
firecrawl:mainfrom
genius-0963:fix/issue-163
Open

genius-0963 wants to merge 1 commit into
firecrawl:mainfrom
genius-0963:fix/issue-163

Conversation

@genius-0963

@genius-0963 genius-0963 commented Nov 16, 2026 •

Copy link
Copy Markdown

Summary

Fixes #163

setup mcp pinned add-mcp@1.14.0, which suffered from a deep-merge bug when updating an existing server configuration (such as an older stdio-style firecrawl entry in ~/.codex/config.toml). This created an invalid hybrid configuration combining stdio and remote fields (url is not supported for stdio), preventing Codex from initializing chats.

Upstream resolved this issue in add-mcp 2.x (neon-solutions/add-mcp#86) by replacing existing server entries atomically instead of deep-merging them. Bumping the pin to add-mcp@2.6.1 brings this fix to Firecrawl CLI users while maintaining an exact version pin for supply-chain reproducibility.

Changes

  • src/commands/setup.ts: Bump ADD_MCP_PACKAGE from add-mcp@1.14.0 to add-mcp@2.6.1.
  • src/__tests__/commands/setup.test.ts: Update test expectations to assert add-mcp@2.6.1.

Tests

  • pnpm run type-check: TypeScript type check passed cleanly with 0 errors (tsc --noEmit).
  • npx vitest run src/__tests__/commands/setup.test.ts: All 97 setup unit tests passed.
  • pnpm run test: Entire test suite passed (51 test files passed, 2 skipped, 925 tests passed).
  • pnpm run build: Build succeeded cleanly (tsc).

Summary by cubic

Bumps add-mcp in setup mcp from 1.14.0 to 2.6.1 to fix a deep-merge bug that corrupted existing server configurations, such as older stdio-style firecrawl entries, by creating an invalid hybrid of stdio and remote fields that prevented Codex from initializing chats. Upstream fixed this by replacing server entries atomically instead of deep-merging. Test expectations are updated to assert the new pin.

Written for commit 8230f29. Summary will update on new commits.

View guided diff

add-mcp 1.14.0 deep-merges server entries instead of replacing them
atomically, leaving invalid hybrid stdio and remote settings in agent
configurations such as Codex when reinstalling or updating from older
stdio setups. Upstream resolved this in neon-solutions/add-mcp#86.

Bump ADD_MCP_PACKAGE from add-mcp@1.14.0 to add-mcp@2.6.1 and update
test expectations accordingly.

Fixes firecrawl#163

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would auto-approve. Bumps the pinned add-mcp package used by setup mcp from 1.14.0 to 2.6.1 and updates setup tests to assert the new pin. The change is confined to the setup command's dependency choice and brings the upstream fix for existing-config corruption.
Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack

View guided diff | Re-trigger cubic

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setup mcp can brick Codex (invalid config: url is not supported for stdio) via add-mcp merge bug

1 participant