Repository navigation
fix(setup): bump add-mcp to 2.6.1 to fix deep-merge config corruption - #387
Open
genius-0963 wants to merge 1 commit into
Open
genius-0963 wants to merge 1 commit into
genius-0963 wants to merge 1 commit into
Conversation
add-mcp 1.14.0 deep-merges server entries instead of replacing them atomically, leaving invalid hybrid stdio and remote settings in agent configurations such as Codex when reinstalling or updating from older stdio setups. Upstream resolved this in neon-solutions/add-mcp#86. Bump ADD_MCP_PACKAGE from add-mcp@1.14.0 to add-mcp@2.6.1 and update test expectations accordingly. Fixes firecrawl#163
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Bumps the pinned add-mcp package used by setup mcp from 1.14.0 to 2.6.1 and updates setup tests to assert the new pin. The change is confined to the setup command's dependency choice and brings the upstream fix for existing-config corruption.
Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack
View guided diff | Re-trigger cubic
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #163
setup mcppinnedadd-mcp@1.14.0, which suffered from a deep-merge bug when updating an existing server configuration (such as an older stdio-stylefirecrawlentry in~/.codex/config.toml). This created an invalid hybrid configuration combining stdio and remote fields (url is not supported for stdio), preventing Codex from initializing chats.Upstream resolved this issue in
add-mcp2.x (neon-solutions/add-mcp#86) by replacing existing server entries atomically instead of deep-merging them. Bumping the pin toadd-mcp@2.6.1brings this fix to Firecrawl CLI users while maintaining an exact version pin for supply-chain reproducibility.Changes
src/commands/setup.ts: BumpADD_MCP_PACKAGEfromadd-mcp@1.14.0toadd-mcp@2.6.1.src/__tests__/commands/setup.test.ts: Update test expectations to assertadd-mcp@2.6.1.Tests
pnpm run type-check: TypeScript type check passed cleanly with 0 errors (tsc --noEmit).npx vitest run src/__tests__/commands/setup.test.ts: All 97 setup unit tests passed.pnpm run test: Entire test suite passed (51 test files passed, 2 skipped, 925 tests passed).pnpm run build: Build succeeded cleanly (tsc).Summary by cubic
Bumps
add-mcpinsetup mcpfrom 1.14.0 to 2.6.1 to fix a deep-merge bug that corrupted existing server configurations, such as older stdio-stylefirecrawlentries, by creating an invalid hybrid of stdio and remote fields that prevented Codex from initializing chats. Upstream fixed this by replacing server entries atomically instead of deep-merging. Test expectations are updated to assert the new pin.Written for commit 8230f29. Summary will update on new commits.