Accept JsonSlabs files in publish endpoint#696
Open
mstange wants to merge 3 commits into
Open
Conversation
canova
requested changes
Jul 10, 2026
canova
left a comment
canova
left a comment
Member
There was a problem hiding this comment.
Looks reasonable to me! I have 1 small question regarding very short jsons, but happy to go either way. Let me know what you think!
mstange
force-pushed
the
allow-jslb
branch
2 times, most recently
from
fcbbb93 to
ccc4f4c
Compare
The next commit will add a dependency to json-slabs, which is an ESM-only module and needs to be added to transformIgnorePatterns so that Jest can handle it. Without this change, transformIgnorePatterns would not apply to anything under node_modules (because .babelrc stops applying in any directory that has a package.json). Using the name babel.config.json turns it into a "project-wide" configuration: https://babeljs.io/docs/config-files#project-wide-configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the profiler front-end we want to start uploading profiles in the JsonSlabs (JSLB) binary container format, so that we don't have to spend time encoding long arrays of numbers to JSON strings.
The server currently rejects such files because it scans for an opening curly brace. This PR adapts the validation code to allow JSLB files.