Remove unused samples.thread column - #6151
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6151 +/- ##
=======================================
Coverage 83.49% 83.49%
=======================================
Files 344 344
Lines 36882 36870 -12
Branches 10241 10335 +94
=======================================
- Hits 30793 30783 -10
+ Misses 5661 5660 -1
+ Partials 428 427 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
canova
reviewed
Jul 10, 2026
canova
left a comment
canova
left a comment
Member
There was a problem hiding this comment.
Ah weird. Yeah, I think we wanted to show which samples came from which thread at some point. But better to remove it.
Comment on lines
+152
to
+154
| // Legacy: older profiles produced by merging may have a per-sample | ||
| // origin-thread column. Not written by current code, but tolerated on | ||
| // input so pre-existing profiles still parse. |
Member
There was a problem hiding this comment.
Do we still need to keep these types here? Isn't it better to remove them so we can make sure that they are not used by mistake later?
Also this part of the comment doesn't make sense: "... but tolerated on input so pre-existing profiles still parse". We don't usually care if a table has extra columns.
Contributor
Author
There was a problem hiding this comment.
Oh yes that comment indeed makes no sense.
I was torn on whether to remove the fields from the types. I thought that maybe in the future we might want to have an upgrader that takes that information from old profiles which had it... nevermind, typing it out I realize that this is not going to happen. It's rare for somebody to use the comparison view and even rarer that they would upload the comparison profile. I'll clean this up.
| // Legacy: older profiles produced by merging may have a per-sample | ||
| // origin-thread column. Not written by current code, but tolerated on | ||
| // input so pre-existing profiles still parse. | ||
| threadId?: Tid[]; |
mstange
force-pushed
the
push-xxpomkrrlpwz
branch
from
July 10, 2026 21:22
7bc758e to
e889c59
Compare
canova
approved these changes
Jul 13, 2026
This was added by the merging/diffing code and propagated in various places, but never actually read. There is a possibility that we may want to make use of this field in the future, but it's been many years and it hasn't happened, so let's just remove it for now. We can always add it back once we need it.
mstange
force-pushed
the
push-xxpomkrrlpwz
branch
from
July 13, 2026 16:32
e889c59 to
31bd60e
Compare
mstange
enabled auto-merge
July 13, 2026 16:32
mstange
added a commit
that referenced
this pull request
Jul 13, 2026
<!-- profiler-preview-links:start --> [Main](https://main--perf-html.netlify.app/) | [Deploy preview](https://deploy-preview-6174--perf-html.netlify.app/) <!-- profiler-preview-links:end --> The auto-rebase of #6151 over #6168 caused a typecheck failure and auto-merge merged anyway. I've now added the "typecheck (ubuntu-latest)" task to the required passing tasks in the branch protection rules so this shouldn't happen again.
Merged
canova
added a commit
that referenced
this pull request
Jul 21, 2026
Changes: [Sky Ning] Skip preview links for non-main PRs (#6161) [spokodev] fix(gecko-upgrade): don't crash on a counter with empty sample_groups (#6160) [fatadel] Show counter values over time in profiler-cli (#6136) [Markus Stange] Make profile-conversion snapshots more compact and meaningful (#6152) [Markus Stange] More typed arrays: sample + counter times, some frametable columns (#6139) [Nazım Can Altınova] Only render a marker url field as a link when the whole value is a URL (#6163) [fatadel] Show each counter's owning process in profiler-cli (#6164) [Nazım Can Altınova] Document the pre-existing thread info and network JSON schemas in the cli (#6171) [Markus Stange] Copy column contents in getRawSamplesTableBuilderFromExisting for consistency (#6168) [Markus Stange] Convert eligible columns to typed arrays when outputting from profiler-edit (#6167) [Markus Stange] Remove unused samples.thread column (#6151) [Markus Stange] Fixed botched merge which broke 'yarn ts' (#6174) [Nazım Can Altınova] Add marker handles to `profiler-cli thread network` (#6172) [Markus Stange] Update json-slabs 0.3.0 → 0.4.0 (major) (#6176) [Nazım Can Altınova] Surface network activity across profiler-cli (#6175) [Nazım Can Altınova] Add `profile meta` command to profiler-cli (#6177) [Markus Stange] Allow raw marker table's `startTime` and `endTime` columns to be Float64Array (#6169) [nightcityblade] Fix light theme text selection colors (#6186) [Nazım Can Altınova] Import source map URLs from Chrome DevTools traces (#6190) [Nazım Can Altınova] Rename yarn `build-profiler-cli` script to `build-cli` (#6191) [Nazım Can Altınova] Migrate husky to version 9 (#6201) [Nazım Can Altınova] Fix horizontal overflow when the transform navigator is long (#6199) [fatadel] Add a 'hexadecimal' marker schema field format (#6197) [Nazım Can Altınova] Bump source-map to 0.8.0 and remove the old type workaround (#6202) [Nazım Can Altınova] 🔃 Sync: l10n -> main (July 21, 2026) (#6209) And special thanks to our localizers: fr: parmegiani.thomas fr: Théo Chevalier sr: Марко Костић (Marko Kostić) sv-SE: Luna Jernberg tr: Grk zh-CN: Ariel zh-CN: Olvcpr423
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
This was added by the merging/diffing code and propagated in various places, but never actually read. There is a possibility that we may want to make use of this field in the future, but it's been many years and it hasn't happened, so let's just remove it for now. We can always add it back once we need it.
I noticed it because it ends up in the "compact" speedometer profiles from CI via
profiler-edit --merge-non-overlapping-threads-by-name.