profiler-cli: include per-marker fields and data in --list --json - #6275
Open
fqueze wants to merge 1 commit into
Open
profiler-cli: include per-marker fields and data in --list --json#6275fqueze wants to merge 1 commit into
fqueze wants to merge 1 commit into
Conversation
`thread markers --list --json` could filter on a payload field
(`--search eventType:keydown`) without returning it, so reading the values back
meant one `marker info` call per marker. Rows now carry `markerType`, `fields`,
`data` and `innerWindowID`; no existing key changes value.
`data` elides a CompositorScreenshot's base64 JPEG to
`{ elided: true, length, preview }`, which keeps a 100-row response at 27KB
instead of 940KB. Elision is keyed by field identity rather than size: a
screenshot URL and a real `Preference Read.prefValue` measured 2855 and 2939
chars, so no byte cap separates them.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6275 +/- ##
=======================================
Coverage 83.79% 83.80%
=======================================
Files 350 350
Lines 37583 37615 +32
Branches 10459 10469 +10
=======================================
+ Hits 31492 31522 +30
- Misses 5664 5666 +2
Partials 427 427 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
thread markers --list --jsoncould filter on a payload field (--search eventType:keydown) without returning it, so reading the values back meant onemarker infocall per marker. Rows now carrymarkerType,fields,dataandinnerWindowID; no existing key changes value.dataelides a CompositorScreenshot's base64 JPEG to{ elided: true, length, preview }, which keeps a 100-row response at 27KB instead of 940KB. Elision is keyed by field identity rather than size: a screenshot URL and a realPreference Read.prefValuemeasured 2855 and 2939 chars, so no byte cap separates them.