profiler-cli: add profile markers for cross-thread marker search - #6276
Open
fqueze wants to merge 1 commit into
Open
profiler-cli: add profile markers for cross-thread marker search#6276fqueze wants to merge 1 commit into
fqueze wants to merge 1 commit into
Conversation
thread markers searches one thread, so finding which of 95 threads saw a marker meant a shell loop of one invocation per thread. profile markers searches every thread in one call and reports matches with a thread column, following the shape of profile logs. The command requires at least one filter: unfiltered it would print an arbitrary slice of 2.4M markers, which answers no question. An explicit --limit opts into browsing anyway. Like thread markers --list, a filtered query returns every match rather than a truncated default, so a search never silently hides hits. Rows are capped at 100000, the most the reply can carry; the per-thread counts stay exact.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6276 +/- ##
==========================================
+ Coverage 83.79% 83.82% +0.02%
==========================================
Files 350 350
Lines 37583 37662 +79
Branches 10459 10493 +34
==========================================
+ Hits 31492 31569 +77
- Misses 5664 5666 +2
Partials 427 427 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
thread markers searches one thread, so finding which of 95 threads saw a marker meant a shell loop of one invocation per thread. profile markers searches every thread in one call and reports matches with a thread column, following the shape of profile logs.
The command requires at least one filter: unfiltered it would print an arbitrary slice of 2.4M markers, which answers no question. An explicit --limit opts into browsing anyway.
Like thread markers --list, a filtered query returns every match rather than a truncated default, so a search never silently hides hits. Rows are capped at 100000, the most the reply can carry; the per-thread counts stay exact.