Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6293 +/- ##
=======================================
Coverage 84.95% 84.96%
=======================================
Files 359 359
Lines 39137 39152 +15
Branches 11091 11115 +24
=======================================
+ Hits 33249 33265 +16
+ Misses 5451 5450 -1
Partials 437 437 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Bug for the Gecko side - https://bugzilla.mozilla.org/show_bug.cgi?id=2068137. |
|
@mstange A kind reminder for review 😌 |
mstange
left a comment
mstange
left a comment
There was a problem hiding this comment.
Sorry about the somewhat non-actionable feedback here - I'm curious if you have ideas or opinions.
| top: CssPixels; | ||
| height: CssPixels; | ||
| background: MarkerSchemaStyleColor; | ||
| squareCorners: boolean; | ||
| borderLeft: MarkerSchemaStyleColor | null; | ||
| borderRight: MarkerSchemaStyleColor | null; |
There was a problem hiding this comment.
I think the color is worth having. I'm not sure what to do about the other properties. Putting them all in here feels like we're giving profiles too much control over our UI. Also, the existing code is a bit of a mess - nobody has looked at it in a long time and it hasn't been updated as the markers that Firefox emitted changed. For example, I think the RefreshDriverTick doesn't actually apply anymore - either it doesn't match the marker, or the markers ask to not be shown in the timeline (because they're Text markers? not sure) so I think nothing actually uses squareCorners:false.
Maybe as a first pass we should remove marker styles which aren't matching any markers in profiles from modern Firefox anymore? And then we can remove unused marker style properties. And then we can think about whether we want top and height in there.
The optional `color` field takes a graph color and replaces the background of the marker type's style.
Markers without a valid `colorField` value are drawn in their schema's `color` instead of the default blue.
Main | Deploy preview
Timeline marker styles are currently selected from a hardcoded table keyed by marker
data.type. The style objects also contain methods, so they cannot be stored as marker schema metadata.This PR makes marker styles serializable and stores them in marker schemas. Timeline rendering now reads styles from the schemas, while preserving marker-name overrides.
Profile processing and the processed-profile upgrader derive the existing styles for schemas without this metadata. A follow-up Gecko change will populate the style field in Gecko marker schemas.
Closes #6292
Profile