Skip to content

Allow typed arrays in the nativeSymbols table - #6300

Open
mstange wants to merge 2 commits into
firefox-devtools:mainfrom
mstange:push-lxkyzqoxypoq
Open

Allow typed arrays in the nativeSymbols table#6300
mstange wants to merge 2 commits into
firefox-devtools:mainfrom
mstange:push-lxkyzqoxypoq

Conversation

@mstange

@mstange mstange commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Main | Deploy preview

This adds a new profile version and migrates profile.shared.nativeSymbols to a typed array representation, in order to reduce the time we spend parsing JSON when we load profiles from JSLB files.

Size profiles: before / after

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.84%. Comparing base (e6bc941) to head (ee6d6e8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/profile-logic/process-profile.ts 80.00% 1 Missing ⚠️
src/profile-logic/processed-profile-versioning.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6300      +/-   ##
==========================================
+ Coverage   83.82%   83.84%   +0.01%     
==========================================
  Files         350      350              
  Lines       37744    37761      +17     
  Branches    10646    10655       +9     
==========================================
+ Hits        31638    31659      +21     
+ Misses       5677     5673       -4     
  Partials      429      429              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mstange mstange changed the title WIP typed arrays in nativeSymbols table Allow typed arrays in the nativeSymbols table Sep 3, 2026
@mstange
mstange marked this pull request as ready for review September 3, 2026 13:31
@mstange
mstange requested a review from canova September 3, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant