Repository navigation
Point bootstrapped profiler-cli users at mach bootstrap for new profies that the CLI can't parse - #6443
Open
canova wants to merge 1 commit into
Open
Point bootstrapped profiler-cli users at mach bootstrap for new profies that the CLI can't parse#6443canova wants to merge 1 commit into
canova wants to merge 1 commit into
Conversation
…les that the CLI can't parse When profiler-cli is installed by './mach bootstrap', it comes from Firefox's in-tree toolchain, so 'npm install -g' is the wrong advice for a profile that is too new. Detect the bootstrapped copy by its location in the mozbuild state directory and tell those users to update their Firefox checkout and rerun './mach bootstrap' instead.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6443 +/- ##
==========================================
+ Coverage 84.81% 84.95% +0.14%
==========================================
Files 358 359 +1
Lines 38981 39137 +156
Branches 11027 11096 +69
==========================================
+ Hits 33061 33249 +188
+ Misses 5483 5451 -32
Partials 437 437 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
When profiler-cli is installed by './mach bootstrap', it comes from Firefox's in-tree toolchain, so
npm install -gis the wrong advice for a profile that is too new. Detect the bootstrapped copy by its location in the mozbuild state directory and tell those users to update their Firefox checkout and rerun './mach bootstrap' instead.