Skip to content

Add tooltip to memory dropdown select element #6444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MM071022 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add tooltip to memory dropdown select element #6444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 37 additions & 33 deletions src/components/shared/CallTreeStrategySetting.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// and various allocation call trees. It is only shown when the profile includes
// allocation data.

import { PureComponent } from 'react';
import { useLocalization } from '@fluent/react';
import { Localized } from '@fluent/react';

import { changeCallTreeSummaryStrategy } from 'firefox-profiler/actions/profile-view';
Expand Down Expand Up @@ -48,42 +48,46 @@ const STRATEGY_L10N_IDS: Record<CallTreeSummaryStrategy, string> = {
'StackSettings--call-tree-strategy-native-deallocations-sites',
};

class CallTreeStrategySettingImpl extends PureComponent<Props> {
_onCallTreeSummaryStrategyChange = (
e: React.ChangeEvent<HTMLSelectElement>
) => {
this.props.changeCallTreeSummaryStrategy(
function CallTreeStrategySettingImpl({
availableCallTreeSummaryStrategies,
callTreeSummaryStrategy,
changeCallTreeSummaryStrategy,
}: Props) {
const { l10n } = useLocalization();

const handleChange = (e: React.ChangeEvent<HTMLSelectElement>) => {
changeCallTreeSummaryStrategy(
toValidCallTreeSummaryStrategy(e.currentTarget.value)
);
};

override render() {
const { availableCallTreeSummaryStrategies, callTreeSummaryStrategy } =
this.props;

return (
<>
<label>
<Localized id="StackSettings--use-data-source-label" />{' '}
<select
className="stackSettingsSelect"
onChange={this._onCallTreeSummaryStrategyChange}
value={callTreeSummaryStrategy}
>
{availableCallTreeSummaryStrategies.map((strategy) => (
<Localized
id={STRATEGY_L10N_IDS[strategy]}
attrs={{ title: true }}
key={strategy}
>
<option value={strategy}></option>
</Localized>
))}
</select>
</label>
</>
);
}
const selectedTitle = l10n.getString(
STRATEGY_L10N_IDS[callTreeSummaryStrategy]
);

return (
<>
<label>
<Localized id="StackSettings--use-data-source-label" />{' '}
<select
className="stackSettingsSelect"
onChange={handleChange}
value={callTreeSummaryStrategy}
title={selectedTitle}
>
{availableCallTreeSummaryStrategies.map((strategy) => (
<Localized
id={STRATEGY_L10N_IDS[strategy]}
attrs={{ title: true }}
key={strategy}
>
<option value={strategy}></option>
</Localized>
))}
</select>
</label>
</>
);
}

export const CallTreeStrategySetting = explicitConnect<
Expand Down
Loading